Skip to content

BUG: PeriodIndex.get_loc incorrectly raising ValueError instead of KeyError #36015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 1, 2020
Merged

BUG: PeriodIndex.get_loc incorrectly raising ValueError instead of KeyError #36015

merged 29 commits into from
Sep 1, 2020

Conversation

jbrockmendel
Copy link
Member

jbrockmendel and others added 26 commits August 20, 2020 21:19
@jbrockmendel
REF: remove unnecesary try/except
4c5eddd
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
c632c9f 
…f-blockwise-3
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
9e64be3 
…f-blockwise-3
@mathurk1 @jbrockmendel
TST: add test for agg on ordered categorical cols (pandas-dev#35630)
42649fb
@tkmz-n @jbrockmendel
TST: resample does not yield empty groups (pandas-dev#10603) (pandas-…
47121dd 
…dev#35799)
@jbrockmendel
revert accidental rebase
1decb3e
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
57c5dd3 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
a358463 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
ffa7ad7 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
e5e98d4 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
408db5a 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
d3493cf 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
75a805a 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
9f61070 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
2d10f6e 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
3e20187 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
e27d07f 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
c52bed4 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
b69d4d7 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
1c5f8fd 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
061c9e2 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
0129a83 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
4d0d8e8 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
715848f 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
b7b1851 
…gs-indexing-2
@jbrockmendel
BUG: PeriodIndex.get_loc incorrectly raising ValueError instead of Ke…
4a0b9d4 
…yError
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Period Period data type labels Sep 1, 2020
@jreback jreback added this to the 1.2 milestone Sep 1, 2020
jreback
jreback requested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, just comments on the version that we push this.

@jreback jreback modified the milestone: 1.2 Sep 1, 2020
@jreback jreback merged commit bdd5d4c into pandas-dev:master Sep 1, 2020
@jbrockmendel jbrockmendel deleted the bugs-indexing-2 branch September 2, 2020 01:02
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
BUG: PeriodIndex.get_loc incorrectly raising ValueError instead of Ke…
ed4ac31 
…yError (pandas-dev#36015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Period Period data type
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: PeriodIndex.get_loc should raise KeyError
4 participants
@jbrockmendel @jreback @mathurk1 @tkmz-n