DOC clean up doc/source/getting_started/overview.rst #35981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Aug 30, 2020
| @@ -174,4 +174,3 @@ License | |||
| ------- | |||
|
|
|||
| .. literalinclude:: ../../../LICENSE | |||
|
|
|||
There was a problem hiding this comment.
I think the blank line at the end of the file was fine, could you revert this?
There was a problem hiding this comment.
I have added the space back in the latest commit.
Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
| @@ -72,7 +72,7 @@ Some other notes | |||
| extensively tweaked in `Cython <https://cython.org>`__ code. However, as with | |||
| anything else generalization usually sacrifices performance. So if you focus | |||
| on one feature for your application you may be able to create a faster | |||
| specialized tool. | |||
| -specialized tool. | |||
There was a problem hiding this comment.
I think this was fine as it was before too, and the hyphen seems out-of-line with the others. Did you try building this page of the docs locally?
There was a problem hiding this comment.
Yeah, I think that is causing a problem in the build. I'll revert it back.
MarcoGorelli
changed the title
MarcoGorelli
changed the title
|
All checks have passed without any conflicts. I think we're good to push the code and close the issue. |
mroeschke
approved these changes
Aug 31, 2020
|
Thanks @Bhard27 |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 31, 2020
* improved the documentation * Update doc/source/getting_started/overview.rst Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com> * new commit * content changed * new commit Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* improved the documentation * Update doc/source/getting_started/overview.rst Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com> * new commit * content changed * new commit Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.