Skip to content

TYP: Remove NDFrame._add_series_or_dataframe_operations #35957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

topper-123
Copy link
Contributor

Refactoring NDFrame._add series or dataframe class method helps with typing.

@topper-123 topper-123 changed the title TYP: Remove NDFrame._add series or dataframe TYP: Remove NDFrame._add_series_or_dataframe_operations Aug 28, 2020
@jbrockmendel
Copy link
Member

LGTM pending green

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @topper-123 lgtm pending lint and docstring fixups

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Aug 28, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 28, 2020
@simonjayhawkins simonjayhawkins merged commit 9632f2e into pandas-dev:master Aug 30, 2020
@simonjayhawkins
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the remove_add_series_or_dataframe_operations branch August 30, 2020 12:54
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Aug 31, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants