Skip to content

add web/ directory to isort checks #35709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2020
Merged

add web/ directory to isort checks #35709

merged 2 commits into from
Aug 13, 2020

Conversation

el-iot
Copy link
Contributor

@el-iot el-iot commented Aug 13, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@el-iot el-iot mentioned this pull request Aug 13, 2020
Merged
5 tasks
@jreback jreback added the Code Style Code style, linting, code_checks label Aug 13, 2020
@jreback jreback added this to the 1.2 milestone Aug 13, 2020
@jreback
Copy link
Contributor

jreback commented Aug 13, 2020

pls rebase as this should fail (as it doesn''t include the check) and then ping on green

@el-iot
Copy link
Contributor Author

el-iot commented Aug 13, 2020

@jreback all clear!

@jreback jreback merged commit 7a67592 into pandas-dev:master Aug 13, 2020
@jreback
Copy link
Contributor

jreback commented Aug 13, 2020

thanks @el-iot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@el-iot @jreback