REF/PERF: Move MultiIndex._tuples to MultiIndex._cache #35641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the heavy-to-calculate
MultiIndex.values
attribute is cached inMultiIndex._tuples
. It would be more dogmatic to store it inMultiIndex._cache
IMO, which is what this PR does.This has the added benefit of
._values
getting copied over to new copies of the MultiIndex, so also gives a performance boost in cases where copying is needed: