Skip to content

DOC: extra closing parens make example invalid. #35316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jul 17, 2020

No attached issues or need for what's new / test... unless you want to actually get a linter the parse the docstrings and make the the examples are syntactically correct ?

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Jul 17, 2020

we do run some but not all doc-tests which run the doc-strings

happy to have a follow on which expands that check (see code_check.sh)

@jreback jreback added the Code Style Code style, linting, code_checks label Jul 17, 2020
@jreback jreback added this to the 1.1 milestone Jul 17, 2020
@jreback jreback merged commit 05a41bc into pandas-dev:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants