-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Unpin pytest #35272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Unpin pytest #35272
Changes from 10 commits
1b0cbbc
c2b9529
4afaa18
bec7674
d1a8242
c9f7643
661836f
34b9925
56c33a7
e302207
5956e8d
0d20058
23305de
fa814c1
2df9a4c
595a3d8
24947db
c39a531
86d3c3c
a34d3e9
7dcb82f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,4 @@ dependencies: | |
- pip | ||
- pip: | ||
- cython>=0.29.16 | ||
- pytest>=5.0.1,<6.0.0rc0 | ||
- pytest>=5.0.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1299,7 +1299,8 @@ def test_series_groupby_on_2_categoricals_unobserved( | |
): | ||
# GH 17605 | ||
if reduction_func == "ngroup": | ||
pytest.skip("ngroup is not truly a reduction") | ||
# https://github.com/pytest-dev/pytest/issues/7495 | ||
pytest.skip("ngroup is not truly a reduction") # type: ignore | ||
|
||
if reduction_func == "corrwith": # GH 32293 | ||
mark = pytest.mark.xfail( | ||
|
@@ -1332,7 +1333,8 @@ def test_series_groupby_on_2_categoricals_unobserved_zeroes_or_nans( | |
# Tests whether the unobserved categories in the result contain 0 or NaN | ||
|
||
if reduction_func == "ngroup": | ||
pytest.skip("ngroup is not truly a reduction") | ||
# https://github.com/pytest-dev/pytest/issues/7495 | ||
pytest.skip("ngroup is not truly a reduction") # type: ignore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tbh here, this is only causing errors since the function is being checked since we have type annotations in the function signature. I think our policy is that we don't type check the tests themselves. maybe I should remove the type annotations here instead. @WillAyd There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @WillAyd because have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed type annotations from pandas/tests/groupby/test_categorical.py. will remove pytest pin from environment.yml after ci run. |
||
|
||
if reduction_func == "corrwith": # GH 32293 | ||
mark = pytest.mark.xfail( | ||
|
@@ -1380,7 +1382,8 @@ def test_dataframe_groupby_on_2_categoricals_when_observed_is_true(reduction_fun | |
# Ensure that df.groupby, when 'by' is two pd.Categorical variables, | ||
# does not return the categories that are not in df when observed=True | ||
if reduction_func == "ngroup": | ||
pytest.skip("ngroup does not return the Categories on the index") | ||
# https://github.com/pytest-dev/pytest/issues/7495 | ||
pytest.skip("ngroup does not return the Categories on the index") # type: ignore # noqa: E501 | ||
|
||
df = pd.DataFrame( | ||
{ | ||
|
@@ -1410,7 +1413,8 @@ def test_dataframe_groupby_on_2_categoricals_when_observed_is_false( | |
# returns the categories that are not in df when observed=False/None | ||
|
||
if reduction_func == "ngroup": | ||
pytest.skip("ngroup does not return the Categories on the index") | ||
# https://github.com/pytest-dev/pytest/issues/7495 | ||
pytest.skip("ngroup does not return the Categories on the index") # type: ignore # noqa:E501 | ||
|
||
if reduction_func == "count": # GH 35028 | ||
mark = pytest.mark.xfail( | ||
|
Uh oh!
There was an error while loading. Please reload this page.