Skip to content

TST: Add test for category equalness on applies (#21239) #35125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2020
Merged

TST: Add test for category equalness on applies (#21239) #35125

merged 1 commit into from
Jul 6, 2020

Conversation

gabrielNT
Copy link
Contributor

@gabrielNT gabrielNT commented Jul 4, 2020 •
edited
Loading

The test checks if equalness comparisons through df.apply() works correctly for the categorical dtype, especially with np.NaN and None values.

WillAyd
WillAyd approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @mroeschke

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jul 6, 2020
@mroeschke mroeschke added this to the 1.1 milestone Jul 6, 2020
@mroeschke mroeschke merged commit 9e44618 into pandas-dev:master Jul 6, 2020
@mroeschke
Copy link
Member

Thanks @gabrielNT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Wrong behaviour of None/np.nan in 'category' type columns
3 participants
@gabrielNT @mroeschke @WillAyd