-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fixed #34859: Added support for '0' and '1' in BooleanArray._from_sequence_of_strings method #35061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test that this works for read_csv
?
@TomAugspurger Can you please suggest me where would this test be appropriate to add.? |
In pandas/tests/io/parser/test_dtypes.py, around the `test_boolean_dtype`
test.
…On Wed, Jul 1, 2020 at 1:29 AM SanthoshBala18 ***@***.***> wrote:
Can you also add a test that this works for read_csv?
@TomAugspurger <https://github.com/TomAugspurger> Can you please suggest
me where would this test be appropriate to add.?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35061 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIX3V46XPEEM3NED553RZLJUVANCNFSM4OMGAW3Q>
.
|
@TomAugspurger Thanks, I have added the tests. Any reason why the CI build would fail.? |
Probably just some instability in conda / cloudflare. I've restarted the failed builds. |
thanks @SanthoshBala18 very nice |
Don't we need some documentation for this? |
for what reason? bool already does this and is pretty standard this is just compatibility |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff