Skip to content

Fixed #34859: Added support for '0' and '1' in BooleanArray._from_sequence_of_strings method #35061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2020

Conversation

SanthoshBala18
Copy link
Contributor

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test that this works for read_csv?

@TomAugspurger TomAugspurger added IO CSV read_csv, to_csv NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Jun 30, 2020
@SanthoshBala18
Copy link
Contributor Author

Can you also add a test that this works for read_csv?

@TomAugspurger Can you please suggest me where would this test be appropriate to add.?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 1, 2020 via email

@SanthoshBala18
Copy link
Contributor Author

@TomAugspurger Thanks, I have added the tests. Any reason why the CI build would fail.?

@TomAugspurger
Copy link
Contributor

Probably just some instability in conda / cloudflare. I've restarted the failed builds.

@jreback jreback added this to the 1.1 milestone Jul 2, 2020
@jreback jreback merged commit 1d6f2bf into pandas-dev:master Jul 2, 2020
@jreback
Copy link
Contributor

jreback commented Jul 2, 2020

thanks @SanthoshBala18 very nice

@kuraga
Copy link

kuraga commented Jul 2, 2020

Don't we need some documentation for this?

@jreback
Copy link
Contributor

jreback commented Jul 2, 2020

for what reason? bool already does this and is pretty standard

this is just compatibility

@SanthoshBala18 SanthoshBala18 deleted the fix-#34859 branch July 3, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ValueError: 1.0 and 0.0 cannot be cast to bool when using pd.read_csv()
4 participants