Skip to content

TST: Adds CategoricalIndex DataFrame from_records test (GH32805) #35055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2020
Merged

TST: Adds CategoricalIndex DataFrame from_records test (GH32805) #35055

merged 4 commits into from
Jul 17, 2020

Conversation

jgulian
Copy link
Contributor

@jgulian jgulian commented Jun 29, 2020

The test checks to make sure from_records loads a DataFrame with a CategorigalIndex as shown in #32805.

@pep8speaks
Copy link

pep8speaks commented Jun 29, 2020 •
edited
Loading

Hello @jgulian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-13 22:30:14 UTC

@WillAyd
Copy link
Member

WillAyd commented Jun 29, 2020

Looks good. Just need to run isort on the affected file to get the right import order

@mroeschke merge if looks good to you

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jun 29, 2020
@mroeschke
Copy link
Member

@jgulian Could you run isort pandas/tests/frame/test_constructors.py?

After that LGTM

@jreback jreback added this to the 1.1 milestone Jul 17, 2020
@jreback jreback added Categorical Categorical Data Type Constructors Series/DataFrame/Index/pd.array Constructors labels Jul 17, 2020
@jreback jreback merged commit d660810 into pandas-dev:master Jul 17, 2020
@jreback
Copy link
Contributor

jreback commented Jul 17, 2020

thanks @jgulian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Constructors Series/DataFrame/Index/pd.array Constructors Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

RecursionError with pd.DataFrame.from_records
5 participants
@jgulian @pep8speaks @WillAyd @mroeschke @jreback