Skip to content

DOC: improve explanation of con argument DataFrame.to_sql #34944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2020

Conversation

arw2019
Copy link
Member

@arw2019 arw2019 commented Jun 23, 2020

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Docs label Jun 23, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jun 23, 2020
Copy link

@gordthompson gordthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. Just a couple of minor suggestions.

@mroeschke mroeschke merged commit 4f7d8bb into pandas-dev:master Jun 25, 2020
@mroeschke
Copy link
Member

Thanks @arw2019

@arw2019 arw2019 deleted the to_sql-improve-doc branch June 26, 2020 17:52
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
…#34944)

* DOC: added example of Connection as con argument to to_sql

* DOC: fixed styling in to_sql docstring

* DOC: fixed styling in to_sql docstring

* DOC: fixed styling in to_sql docstring

* revert accidental changes

* DOC: fixed context manager example in to_sql

* DOC: fixed typo in to_sql docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: to_sql accepting Engine vs. Connectable
4 participants