CLN: day->day_opt, remove unused case in liboffsets.get_day_of_month #34762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jun 14, 2020
| @@ -4095,9 +4093,6 @@ cdef int get_day_of_month(datetime other, day_opt) except? -1: | |||
| elif day_opt == 'business_end': | |||
| # last business day of month | |||
| return get_lastbday(other.year, other.month) | |||
| elif is_integer_object(day_opt): | |||
| days_in_month = get_days_in_month(other.year, other.month) | |||
| return min(day_opt, days_in_month) | |||
| elif day_opt is None: | |||
| # Note: unlike `shift_month`, get_day_of_month does not | |||
| # allow day_opt = None | |||
There was a problem hiding this comment.
I would check if we have tests for this raise case (also doesn't need to be an else anymore as everything returns. followon on).
There was a problem hiding this comment.
yes, we have tests for both the ValueError and NotImplementedError cases here
There was a problem hiding this comment.
as for "else", I get compile-time failures about unreached code
|
thanka followo suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this unused case turns out to be a blocker to making get_day_of_month nogil, which in turn will allow a bunch of de-duplication in this file.