BUG: asymmetric error bars for series (GH9536) #34514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jun 1, 2020
|
Hello @Steffen911! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-17 13:40:41 UTC |
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series # Conflicts: # doc/source/whatsnew/v1.1.0.rst
MarcoGorelli
suggested changes
Jun 12, 2020
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
|
@MarcoGorelli @datapythonista Could one of you review the PR? Or maybe suggest another reviewer? |
datapythonista
approved these changes
Jun 26, 2020
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
…x/9536-asymmetric-error-series
…/Steffen911/pandas into fix/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
WillAyd
requested changes
Jul 6, 2020
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
|
lgtm can u merge master and ping on green |
…x/9536-asymmetric-error-series
…x/9536-asymmetric-error-series
jreback
requested changes
Jul 17, 2020
jreback
approved these changes
Jul 17, 2020
|
lgtm ping on green |
…x/9536-asymmetric-error-series
|
@jreback All tests are green. Travis reports itself as "Passed" when I go to the "Details", but apparently it didn't update the PR check after it has finished. |
|
Thanks @Steffen911! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9536
This fix enables asymmetric errors bars for pd.Series plots. In the current implementation the bars are symmetric, even if two sets of errors are provided.
Took inspirations from #12046