CLN: assorted tslibs cleanups #34432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1325,7 +1325,7 @@ cdef class BusinessDay(BusinessMixin): | |||
| off_str += str(td.microseconds) + "us" | |||
| return off_str | |||
|
|
|||
| if isinstance(self.offset, timedelta): | |||
| if PyDelta_Check(self.offset): | |||
There was a problem hiding this comment.
Cython doesn't optimize this automatically?
(and does this make a noticeable difference?)
There was a problem hiding this comment.
cython does not do this automatically. it makes a small differnece, but enough that we do this in the rest of the cython code
There was a problem hiding this comment.
yeah we use this type of check with datetime types a lot
jreback
approved these changes
May 28, 2020
| @@ -1325,7 +1325,7 @@ cdef class BusinessDay(BusinessMixin): | |||
| off_str += str(td.microseconds) + "us" | |||
| return off_str | |||
|
|
|||
| if isinstance(self.offset, timedelta): | |||
| if PyDelta_Check(self.offset): | |||
There was a problem hiding this comment.
yeah we use this type of check with datetime types a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.