Skip to content

DOC: "Setting layouts" plots' label size GH34305 #34394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2020
Merged

DOC: "Setting layouts" plots' label size GH34305 #34394

merged 4 commits into from
Jun 7, 2020

Conversation

najann
Copy link
Contributor

@najann najann commented May 26, 2020

@najann najann changed the title "Setting layouts" plots' label size DOC: "Setting layouts" plots' label size GH34305 May 27, 2020
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @najann !

So, like this, the first plot I put in the original issue is now legibile - great!

The second one hasn't changed though - could you update that one too?

@dsaxton dsaxton added the Docs label May 28, 2020
@najann najann requested a review from MarcoGorelli May 28, 2020 06:44
Comment on lines 1333 to 1339
.. ipython:: python
:suppress:

import matplotlib

matplotlib.rc('xtick', labelsize=8)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be hidden - if someone wants to reproduce the plot and it looks different, that might be confusing. Would simply increasing the figsize in plt.subplots be enough to make it more legible? Otherwise, can matplotlib.rc('xtick', labelsize=8) be made visible to the readers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I just did not want to mess up the code snippet... but increasing fig size is equally fine!

@@ -1369,6 +1377,7 @@ Another option is passing an ``ax`` argument to :meth:`Series.plot` to plot on a
.. ipython:: python

fig, axes = plt.subplots(nrows=2, ncols=2)
plt.subplots_adjust(wspace=0.2, hspace=0.4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sorry for the nitpick, but could hspace be increased slightly more so there's visual separation between the labels of the top subplots and the titles of the bottom ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer like this - thanks @najann !

@WillAyd WillAyd added this to the 1.1 milestone Jun 7, 2020
@WillAyd WillAyd merged commit 1938b4f into pandas-dev:master Jun 7, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 7, 2020

Great thanks @najann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: "Setting layouts" plots are hard to read
4 participants