Added missing import in boxplot_frame_groupby example

[gsyqax]

• closes groupby boxplot example does not work #28903
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[MarcoGorelli]

Thanks @gsyqax - did you build this page of the documentation locally to check it works?

[gsyqax]

@MarcoGorelli yes, it is working.

I noticed the example also makes use of 'pd' and 'np' alias without importing and aliasing pandas and numpy. I don't think this can lead to confusion. Do you think I should also add those imports?

[MarcoGorelli]

That's OK, it fits with the docstring guide

Import required libraries (except numpy and pandas)

[MarcoGorelli]

@MarcoGorelli yes, it is working.

I just tried building it with your changes and I don't see any plot though, do you?

See the guide I linked to above for how to display plots in documentation examples

[gsyqax]

I'm not seeing any plots either. I thought a plot was not needed since the current version is not showing any either.

I will add the plots and commit again

[pep8speaks]

Hello @gsyqax! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-06 14:53:37 UTC

[gsyqax]

@MarcoGorelli I added some plots and made a few minor changes to make everything clearer, hope it's OK. Also removed whitespace as indicated by pep8speaks.

[MarcoGorelli]

Nice! Thanks, just tried running it and it looks good. Can you just add a space between the two examples, as suggested below?

[MarcoGorelli]

Also, I don't think a whatsnew note is necessary for documentation improvements, could you please revert that change?

[MarcoGorelli]

LGTM

have opened #34353 as I'm not sure what to do about the subplots being too close (but it would warrant a separate PR anyway, I don't think there'd be any need to change that here)

[gsyqax]

Great! Many thanks @MarcoGorelli for all the help, really appreciate it!

[jreback]

cc @datapythonista @jorisvandenbossche @WillAyd

[charlesdong1991]

try boxplot_frame_groupby(grouped, rot=45, fontsize=12, figsize=(8, 10)) for instance? @gsyqax

it will avoid having overlapped subplots and make doc look better

[jorisvandenbossche]

IMO we should not advertise boxplot_frame_groupby like that directly, but rather as df.groupby(..).boxplot(..)

[WillAyd]

Slight preference for what @jorisvandenbossche has suggested above but not a blocker so OK either way

[gsyqax]

I applied the change to the plot fig size and replaced boxplot_frame_groupby by df.groupby.boxplot. I'm keeping the intermediate var 'grouped' to make things easier to read

[TomAugspurger]

@gsyqax can you remove this import.

[jreback]

lgtm. @TomAugspurger

[TomAugspurger]

Thanks @gsyqax!