CLN: Move _convert_to_list_like to common #34127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 12, 2020
pandas/core/common.py
Outdated
|
|
||
|
|
||
| def convert_to_list_like(values): | ||
| if hasattr(values, "dtype"): |
There was a problem hiding this comment.
can u type and add a doc string
make these elif
see where else we can u this
dsaxton
commented
May 12, 2020
|
|
||
| def convert_to_list_like( | ||
| values: Union[Scalar, Iterable, AnyArrayLike] | ||
| ) -> Union[List, AnyArrayLike]: |
There was a problem hiding this comment.
Had to rewrite this a bit to get it to type check
There was a problem hiding this comment.
@dsaxton i noticed you used ABCIndex instead of ABCIndexClass, was that intentional?
There was a problem hiding this comment.
I don't think so, definitely change if you feel it's not correct
dsaxton
commented
May 12, 2020
| @@ -4,17 +4,16 @@ | |||
| Note: pandas.core.common is *not* part of the public API. | |||
| """ | |||
|
|
|||
| import collections | |||
| from collections import abc | |||
| from collections import abc, defaultdict | |||
There was a problem hiding this comment.
Slightly unrelated, but this seems better than mixing the two import styles
jreback
approved these changes
May 13, 2020
|
hmm azure doesnt' seem to be running. can you merge master and ping on green. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.