TST: query with timezone aware index & column #34021
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -695,6 +695,21 @@ def test_inf(self): | |
| result = df.query(q, engine=self.engine, parser=self.parser) | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
||
| def test_check_tz_aware_index_query(self, tz_aware_fixture): | ||
| # https://github.com/pandas-dev/pandas/issues/29463 | ||
| tz = tz_aware_fixture | ||
| df_index = pd.date_range( | ||
| start="2019-01-01", freq="1d", periods=10, tz=tz, name="time" | ||
| ) | ||
| expected = pd.DataFrame(index=df_index) | ||
| df = pd.DataFrame(index=df_index) | ||
| result = df.query('"2018-01-03 00:00:00+00" < time') | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
||
|
There was a problem hiding this comment. can you also test the working case here, e.g. There was a problem hiding this comment. @jreback Done. Please review. There was a problem hiding this comment. @vipinkjonwal thanks for your updates Like this, what's the difference between I think Jeff meant result = df.reset_index().query('"2018-01-03 00:00:00+00" < time')
expected = pd.DataFrame(df_index)
tm.assert_frame_equal(result, expected)There was a problem hiding this comment. @MarcoGorelli , I thought this was already working when the related issue was raised , I've updated the test with suggested changes. |
||
| expected = pd.DataFrame(df_index) | ||
| result = df.reset_index().query('"2018-01-03 00:00:00+00" < time') | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
||
|
|
||
| @td.skip_if_no_ne | ||
| class TestDataFrameQueryNumExprPython(TestDataFrameQueryNumExprPandas): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this,
timeis always greater than2018-01-03 00:00:00+00- I think @mroeschke was suggesting to use, say,2019-01-04inexpected,2019-01-01indf, and then2019-01-03inqueryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoGorelli Thank you for the comment / appreciation.
If we use 2019-01-03 in query it results in earlier problem , because the shape of "expected" and "df" remains the same also their tz is changing , but in query the tz remains constant and when we query it to diff timezone their shape becomes inconsistent as the query tz is always constant. (So it always result in +1 or -1 records and hence fails.)
Hence I think he suggested to use 2018-01-03 , as it will always result in consistent shape while checking tz-aware for all time zones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I'd misunderstood, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, it seems that your index for both
dfandexpectedare identical - if so, can you make a variable to share them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ! Thanks.