REF: avoid importing pd.NA in tslibs #34009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing cimport of pd.NA into tslibs.nattype is a circular dependency (its not actually clear to me why it doesnt raise). I'm finding that its presence is making other refactoring around tslibs.offsets more difficult. This PR moves the import of pd.NA to tslib, breaking the circular dependency.
This does change some behavior, but none that is tested, so we should discuss what places we want to recognize pd.NA. In particular,
pd.Timedelta(pd.NA)
returnsNaT
in master and raisesValueError
in this PR.pd.Timestamp(pd.NA)
andpd.Period(pd.NA)
raise TypeError and ValueError, respectively, in both master and this PR.cc @jorisvandenbossche what is your preferred behavior?