Skip to content

CLN: remove unused out-of-bounds handling #34006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020

Conversation

jbrockmendel
Copy link
Member

We only have one test that goes through the OOB handling code, and that re-raises within the OOB handling. We're better off being strict here like everywhere else rather than having spotty support.

@jreback jreback added Clean Frequency DateOffsets Datetime Datetime data dtype labels May 5, 2020
@jreback jreback added this to the 1.1 milestone May 5, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@jbrockmendel
Copy link
Member Author

clicking through to travis shows green, just hasnt propagated here

@jreback jreback merged commit 5aadb12 into pandas-dev:master May 5, 2020
@jreback
Copy link
Contributor

jreback commented May 5, 2020

thanks!

@jbrockmendel jbrockmendel deleted the offsets-oob branch May 5, 2020 22:40
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype Frequency DateOffsets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants