Skip to content

DOC: ref / val caveat, point at pandas methods #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2013

Conversation

dengemann
Copy link
Contributor

This in part addresses #3340.

I added a few comments in the doc that point users ad using the pandas
at, iat, loc, iloc, etc. methods and included an example similar to
the one exposed in #3340 that addresses some of the reference / value
intricaies encountered with pandas and numpy objects.

To make things clear I selected a rather verbose style.
Let me know if this is over the top ;-)

@jreback
Copy link
Contributor

jreback commented Apr 19, 2013

looks good, I would add the notes using the rst note directive, makes them stand out (with the lines around them)...my 2c

like this

.. note::

   The recent addition of ``.loc`` and ``.iloc`` have enabled users to be quite
   explicit about indexing choices. ``.ix`` allows a great flexibility to specify

@dengemann
Copy link
Contributor Author

@jreback thanks for your pointer. Just pushed another iteration over the text with .rst directives.

@jreback
Copy link
Contributor

jreback commented Apr 19, 2013

next tip:rebase these to a single commit (you don't always want to do this, but in this case since
these are just changes it makes sense)

rebase -i <commit>

use the commit 1 previous to your first commit
you can also do HEAD~4 which in this case will get you that commit

then either squash (s) / fixup (f) the commits to form a bigger one (s preservers the commit message, f does not)

then

git push myfork branch_name -f

will replace all of these commits with a new one.... (w/o the f it just appends new commits)

@dengemann
Copy link
Contributor Author

@jreback here we go ;-)

@ghost
Copy link

ghost commented Apr 20, 2013

@dengemann , can you wrap that text to match the rest of the document?
That's easier to revise in a text editor later on.

@dengemann
Copy link
Contributor Author

Yeah, I forgot about about that, sorry. Hold on.

On Sat, Apr 20, 2013 at 11:54 AM, y-p notifications@github.com wrote:

@dengemann https://github.com/dengemann , can you wrap that text to
match the rest of the document?
That's easier to revise in a text editor later on.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3399#issuecomment-16701562
.

This in part addresses pandas-dev#3340.

I added a few comments in the doc that point users ad using the pandas
at, iat, loc, iloc, etc. methods and included an example similar to
the one exposed in pandas-dev#3340 that addresses some of the reference / value
intricaies encountered with pandas and numpy objects.

CLN: cleanup + edits - addresses recent discussion

CLN: cleanup II

CLN: wrap at 80 chars.

took care of both documents.
@dengemann
Copy link
Contributor Author

Wrapped, rebased.

jreback added a commit that referenced this pull request Apr 20, 2013
DOC: ref / val caveat, point at pandas methods - thanks!
@jreback jreback merged commit c301433 into pandas-dev:master Apr 20, 2013
@jreback
Copy link
Contributor

jreback commented Apr 20, 2013

@dengemann I moved the view vs copy example to consolidate with the section we had for it; I think should actually expand this example to show a proper assignment using .loc/.iloc (using your example), want to do this?

@dengemann
Copy link
Contributor Author

I moved the view vs copy example to consolidate with the section we had for it;

Thanks!

I think should actually expand this example to show a proper assignment using .loc/.iloc (using your example), want to do this?

Sure, I might find some time tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants