BUG: Fix small memory access errors in ujson objToJSON.c #33929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JSON changes look good Out of curiosity is there a guide you can share for running this with valgrind? I’ve tried unsuccessfully in the past but would be interested in knowing how |
|
There is no secret, in this case I did not even to bother debug builds. The only thing to remember nowadays is to use |
These were found (and validated fixed) using valgrind. It is likely that none of these changes should create any issues (except maybe on a debug build of python?). But silencing valgrind warnings is good on its own, to ease possible future debugging using valgrind.
seberg
force-pushed
the
ujson-valgrind-bugfix
branch
from
6e320e3 to
e8153af
Compare
|
OK, this (unsurprisingly) did not change anything with the test, so removed it from the PR, I guess it should be all set, considering that it is a tiny bug fix really? |
|
Travis fail is unrelated, has been affecting a bunch of tests for the last few days |
|
thanks @seberg |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found (and validated fixed) using valgrind. It is likely
that none of these changes should create any issues (except maybe
on a debug build of python?). But silencing valgrind warnings is
good on its own, to ease possible future debugging using valgrind.
NOTE: I removed skipping of
test_astype_generic_timestamp_no_frequency, this is just out of curiosity, I would be very surprised if it made a difference. So this should probably be only merged after undoing the test change.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff