DOC: fix doc for crosstab with Categorical data input #33783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Looks like there are some minor fixes: |
|
Hi, whether I need to close this pull and create another? Thanks, this is my first PR, not very sophisticated about the process. |
|
Oh, I find it start automatically after the push step. Thanks! |
|
Thanks @GYHHAHA ! Could you please include a screenshot of this part of the docs? See building the documentation If you're in the python make.py clean
python make.py --single user_guide/reshaping.rst |
|
Hi, this is the screenshot. Is it OK? Thanks! @MarcoGorelli |
MarcoGorelli
approved these changes
Apr 26, 2020
jreback
reviewed
Apr 27, 2020
|
|
||
| .. ipython:: python | ||
|
|
||
| foo = pd.Categorical(['a', 'b'], categories=['a', 'b', 'c']) | ||
| bar = pd.Categorical(['d', 'e'], categories=['d', 'e', 'f']) | ||
| pd.crosstab(foo, bar) | ||
| pd.crosstab(foo, bar, dropna=False) |
There was a problem hiding this comment.
can u put this one in a separate ipython block and put the comment before that one
|
Hi, this is the screenshot under current status. Thanks for review! @jreback |
|
lgtm long on green |
|
Checks are down, is it ok? Thanks! @jreback |
|
thanks |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* fix doc for crosstab with Categorical data input * fix doc for crosstab with Categorical data input * put dropna=False in a separate ipython block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crosstab function should set dropna=False to keep the categories which not appear in the data, but in the DOC, it seems to be inconsistent with the description. Two examples for comparison may be better for users to get this point.
https://pandas.pydata.org/docs/dev/user_guide/reshaping.html#cross-tabulations