CLN: Split dtype inference tests #33690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -892,25 +872,25 @@ def test_infer_dtype_period(self): | |||
| arr = np.array([pd.Period("2011-01", freq="D"), pd.Period("2011-02", freq="M")]) | |||
| assert lib.infer_dtype(arr, skipna=True) == "period" | |||
|
|
|||
| # starts with nan | |||
There was a problem hiding this comment.
IIRC this comment was related to needing a test specifically for the NaN coming before the period. can you add a comment in the appropriate place to that effect
|
small comment request, otherwise LGTM nice cleanup |
|
thanks @dsaxton would take a followup to use the |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* CLN: Split dtype inference tests * Lint * Include comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up some very large tests in dtypes/test_inference.py