-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) #33509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 7 commits into
pandas-dev:master
from
a-y-khan:better-error-unsupported-hdf5
Apr 17, 2020
Merged
ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) #33509
mroeschke
merged 7 commits into
pandas-dev:master
from
a-y-khan:better-error-unsupported-hdf5
Apr 17, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 13, 2020
…d a test (GH9539)
jreback
requested changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, if you can just move the whatsnew note and ping on green for merge.
doc/source/whatsnew/v1.1.0.rst
Outdated
@@ -98,6 +98,8 @@ Other enhancements | |||
This can be used to set a custom compression level, e.g., | |||
``df.to_csv(path, compression={'method': 'gzip', 'compresslevel': 1}`` | |||
(:issue:`33196`) | |||
- :func:`pandas.read_hdf` has a more explicit error message when loading an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to the IO section
jreback
approved these changes
Apr 17, 2020
Thanks @a-y-khan |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
…9539) (pandas-dev#33509) * ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) * ENH: less convoluted error message (GH9539) * ENH: adding file with an incompatible dataset based on PR feedback and a test (GH9539) * Move note to io section as requested in PR feedback.
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
…9539) (pandas-dev#33509) * ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) * ENH: less convoluted error message (GH9539) * ENH: adding file with an incompatible dataset based on PR feedback and a test (GH9539) * Move note to io section as requested in PR feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
The error message changed since the original bug report but still could be made more clear.