Skip to content

ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) #33509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2020
Merged

ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539) #33509

merged 7 commits into from
Apr 17, 2020

Conversation

a-y-khan
Copy link
Contributor

The error message changed since the original bug report but still could be made more clear.

@a-y-khan a-y-khan requested a review from jreback April 16, 2020 18:03
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, if you can just move the whatsnew note and ping on green for merge.

@@ -98,6 +98,8 @@ Other enhancements
This can be used to set a custom compression level, e.g.,
``df.to_csv(path, compression={'method': 'gzip', 'compresslevel': 1}``
(:issue:`33196`)
- :func:`pandas.read_hdf` has a more explicit error message when loading an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move to the IO section

@jreback jreback added Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore labels Apr 16, 2020
@jreback jreback added this to the 1.1 milestone Apr 16, 2020
@mroeschke mroeschke merged commit 3fdbd22 into pandas-dev:master Apr 17, 2020
@mroeschke
Copy link
Member

Thanks @a-y-khan

@a-y-khan a-y-khan deleted the better-error-unsupported-hdf5 branch April 20, 2020 04:18
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
…9539) (pandas-dev#33509)

* ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539)

* ENH: less convoluted error message (GH9539)

* ENH: adding file with an incompatible dataset based on PR feedback and a test (GH9539)

* Move note to io section as requested in PR feedback.
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
…9539) (pandas-dev#33509)

* ENH: clearer error message if read_hdf loads upsupported HDF file (GH9539)

* ENH: less convoluted error message (GH9539)

* ENH: adding file with an incompatible dataset based on PR feedback and a test (GH9539)

* Move note to io section as requested in PR feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error when loading unsupported HDF5 file
3 participants