DOC: Fixed examples in pandas/core/aggregation.py
#33263
Conversation
| >>> normalize_keyword_aggregation({'output': ('input', 'sum')}) | ||
| ({'input': ['sum']}, ('output',), [('input', 'sum')]) | ||
| >>> normalize_keyword_aggregation({"output": ("input", "sum")}) | ||
| (defaultdict(<class 'list'>, {'input': ['sum']}), ('output',), array([0])) |
There was a problem hiding this comment.
hmm, this output doesn't match the returns section/return type hint.
There was a problem hiding this comment.
@simonjayhawkins Fixed it in eceb678
pandas/core/aggregation.py
Outdated
| @@ -52,17 +56,17 @@ def normalize_keyword_aggregation(kwargs: dict) -> Tuple[dict, List[str], List[i | |||
|
|
|||
| Returns | |||
| ------- | |||
| aggspec : dict | |||
| aggspec : DefaultDict[list] | |||
There was a problem hiding this comment.
What's the reason to use type annotations syntax instead of the docs one we've been using?
There was a problem hiding this comment.
What's the reason to use type annotations syntax instead of the docs one we've been using?
I'll change that, forgot that we use a different syntax for the docs
@datapythonista by "split" you mean, separate PRs? |
|
Yes, I mean separate PRs |
IMO they are related. see #33263 (comment) |
There was a problem hiding this comment.
Didn't see that comment @simonjayhawkins, sorry I missed the context @MomIsBestFriend. I guess you opened a separate PR for the types. In any case, lgtm, thanks!
|
Thanks @MomIsBestFriend |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff