BUG: isna_old with td64, dt64tz, period #33158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Mar 31, 2020
| @@ -297,6 +250,24 @@ def _isna_ndarraylike_old(obj): | |||
| return result | |||
|
|
|||
|
|
|||
| def _isna_string_dtype(values: np.ndarray, dtype: np.dtype, old: bool) -> np.ndarray: | |||
| # Working around NumPy ticket 1542 | |||
There was a problem hiding this comment.
not even sure this is the correct issue anymore :-< but can revist this whole thing later
jreback
added
Clean
Missing-data
|
thxs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffStarted as a CLN branch and i left that in for now, can separate if desired. the bugfix is on L287.