REF: DataFrame.isna internals access #33124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested changes
Mar 30, 2020
| @@ -4478,19 +4478,20 @@ def _maybe_casted_values(index, labels=None): | |||
|
|
|||
| @Appender(_shared_docs["isna"] % _shared_doc_kwargs) | |||
| def isna(self) -> "DataFrame": | |||
| return super().isna() | |||
| result = self._constructor(self._data.isna(func=isna)) | |||
There was a problem hiding this comment.
This should be isna or isna_old depending on the settings?
There was a problem hiding this comment.
(and since that is handled in the isna function, I am not fully sure it will be easier to do it here)
There was a problem hiding this comment.
This should be isna or isna_old depending on the settings?
No, the _isna/_isna_old is reflected in isna
There was a problem hiding this comment.
Ah, I missed that. So it's basically calling that recursively on its parts. OK!
jorisvandenbossche
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.