Skip to content

CLN: Remove GroupByError exception #32952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2020
Merged

CLN: Remove GroupByError exception #32952

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d257695
CLN: Remove GroupByError exception
dsaxton Mar 23, 2020
c1a09f4
No name
dsaxton Mar 23, 2020
ebb897e
Merge remote-tracking branch 'upstream/master' into rm-groupbyerror
dsaxton Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions pandas/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,11 @@ def __setattr__(self, key: str, value):
object.__setattr__(self, key, value)


class GroupByError(Exception):
class DataError(Exception):
pass


class DataError(GroupByError):
pass


class SpecificationError(GroupByError):
class SpecificationError(Exception):
pass


Expand Down Expand Up @@ -372,7 +368,7 @@ def _agg_1dim(name, how, subset=None):
)
return colg.aggregate(how)

def _agg_2dim(name, how):
Copy link
Member Author

@dsaxton dsaxton Mar 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also doesn't seem to be used (the name arg)

def _agg_2dim(how):
"""
aggregate a 2-dim with how
"""
Expand Down