Skip to content

CLN: pandas/_libs/tslibs/nattype.pyx #32888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Mar 21, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This PR is doing basicly two things:

  • Getting rid of noqa: E128 comments.

  • Unifying use ofutil.foo

in some places there was a use of is_integer_object(foo) and in some places there was a use of util.is_integer_object(foo), now util.is_integer_object(foo) is being in use instead.


Benchmarks:

In [1]: from pandas._libs.tslibs.nattype import _make_nat_func 

In [2]: %timeit _make_nat_func("foo", "bar")
120 ns ± 1.01 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each) # Master
117 ns ± 1.47 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each) # PR

@jreback jreback added Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Mar 21, 2020
@jreback jreback added this to the 1.1 milestone Mar 21, 2020
@jreback jreback merged commit 2209d64 into pandas-dev:master Mar 21, 2020
@jreback
Copy link
Contributor

jreback commented Mar 21, 2020

thanks @MomIsBestFriend

SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@ShaharNaveh ShaharNaveh deleted the CLN-_libs-tslibs-nattype branch March 23, 2020 18:36
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants