REF: avoid _internal_get_values in json get_values #32754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty much everything right now goes into |
WillAyd
reviewed
Mar 16, 2020
| @@ -222,13 +222,19 @@ static PyObject *get_values(PyObject *obj) { | |||
|
|
|||
| PRINTMARK(); | |||
|
|
|||
| if (PyObject_HasAttrString(obj, "_internal_get_values")) { | |||
| if (PyObject_TypeCheck(obj, cls_index) || PyObject_TypeCheck(obj, cls_series)) { | |||
There was a problem hiding this comment.
I guess will see on test cases, but is this really required? AFAICT on master _internal_get_values and values return the same for a dt64tz array:
>>> dts = pd.date_range(start="2020-01-01", freq="D", periods=3, tz="US/Pacific")
>>> dts._internal_get_values()
array(['2020-01-01T08:00:00.000000000', '2020-01-02T08:00:00.000000000',
'2020-01-03T08:00:00.000000000'], dtype='datetime64[ns]')
>>> dts.values
array(['2020-01-01T08:00:00.000000000', '2020-01-02T08:00:00.000000000',
'2020-01-03T08:00:00.000000000'], dtype='datetime64[ns]')There was a problem hiding this comment.
its Categorical[dt64tz] and Sparse that make the extra __array__ call necessary
|
lgtm. happy if you guys are. |
WillAyd
approved these changes
Mar 17, 2020
|
Thanks @jbrockmendel |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd
As mentioned in #32731, this changes the behavior for CategoricalIndex[dt64tz] and Series with that for its index. Suggestions for where tests for that should go?
Note: the Categorical[dt64tz] cases still do a trip through object-dtype; I don't want to futz with that in C-space.