-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Track times #32700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Track times #32700
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a431e31
Propagate track times
rbenes acbd5b4
Make both tests
rbenes 8a374de
Unify
rbenes 5a05b5c
Note
rbenes 2f61140
Black
rbenes eb9a4c2
Make it tables < 3.4.3 friendly
rbenes ebbf5ba
Use LooseVersion
rbenes a3ff426
Use default true. Be silent if unsupported pytables
rbenes 190c9e4
Imports arranged
rbenes 7a90718
Mark test as skipif
rbenes dc5566f
Avoid importing tables
rbenes 99b99e1
Revert import tables back to function
rbenes df98a7b
No need for handling of pytables version
rbenes f1fda88
Whats new added
rbenes d76fb37
Docstring added
radekbenesinno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -984,6 +984,7 @@ def put( | |
data_columns: Optional[List[str]] = None, | ||
encoding=None, | ||
errors: str = "strict", | ||
track_times: bool = True, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you update the doc-string, make sure to add a 1.1 versionadded tag There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doc string added |
||
): | ||
""" | ||
Store object in HDFStore. | ||
|
@@ -1010,6 +1011,12 @@ def put( | |
Provide an encoding for strings. | ||
dropna : bool, default False, do not write an ALL nan row to | ||
The store settable by the option 'io.hdf.dropna_table'. | ||
track_times : bool, default True | ||
Parameter is propagated to 'create_table' method of 'PyTables'. | ||
If set to False it enables to have the same h5 files (same hashes) | ||
independent on creation time. | ||
|
||
.. versionadded:: 1.1.0 | ||
""" | ||
if format is None: | ||
format = get_option("io.hdf.default_format") or "fixed" | ||
|
@@ -1027,6 +1034,7 @@ def put( | |
data_columns=data_columns, | ||
encoding=encoding, | ||
errors=errors, | ||
track_times=track_times, | ||
jreback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
) | ||
|
||
def remove(self, key: str, where=None, start=None, stop=None): | ||
|
@@ -1626,6 +1634,7 @@ def _write_to_group( | |
data_columns=None, | ||
encoding=None, | ||
errors: str = "strict", | ||
track_times: bool = True, | ||
): | ||
group = self.get_node(key) | ||
|
||
|
@@ -1688,6 +1697,7 @@ def _write_to_group( | |
dropna=dropna, | ||
nan_rep=nan_rep, | ||
data_columns=data_columns, | ||
track_times=track_times, | ||
) | ||
|
||
if isinstance(s, Table) and index: | ||
|
@@ -4106,8 +4116,8 @@ def write( | |
dropna=False, | ||
nan_rep=None, | ||
data_columns=None, | ||
track_times=True, | ||
): | ||
|
||
if not append and self.is_exists: | ||
self._handle.remove_node(self.group, "table") | ||
|
||
|
@@ -4137,6 +4147,8 @@ def write( | |
# set the table attributes | ||
table.set_attrs() | ||
|
||
options["track_times"] = track_times | ||
|
||
# create the table | ||
table._handle.create_table(table.group, **options) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.