REG: dt64 shift with integer fill_value #32591
Conversation
According to https://pandas.pydata.org/docs/development/policies.html
But perhaps it's OK here since this is fixing a bug (failure to deprecate something in 1.0). I don't have a strong preference. |
jreback
added
the
Missing-data
| fill_value = NaT | ||
| elif not isinstance(fill_value, self._recognized_scalars): | ||
| # only warn if we're not going to raise | ||
| if self._scalar_type is Period and lib.is_integer(fill_value): |
There was a problem hiding this comment.
"is" is on purpose here
pandas/core/arrays/datetimelike.py
Outdated
| elif not isinstance(fill_value, self._recognized_scalars): | ||
| # only warn if we're not going to raise | ||
| if self._scalar_type is Period and lib.is_integer(fill_value): | ||
| # kludge for #31971 |
There was a problem hiding this comment.
can you add a comment of what this is
| if f_ordered: | ||
| new_values = new_values.T | ||
| axis = new_values.ndim - axis - 1 | ||
|
|
There was a problem hiding this comment.
this is similar to the shift we have in block values yes? this should at some point be a routine in missing.py
There was a problem hiding this comment.
ideally doing it in this PR but if too hard to backport ok
There was a problem hiding this comment.
Yah, i was thinking core.algos directory for algorithms-like functions that are specifically only ndarray/EA
|
@jbrockmendel can you update doc-strings, otherwise lgtm. |
|
updated+green; i think ive addressed the relevant comments |
|
thanks, let's see if this backports |
|
@meeseeksdev backport 1.0.x |
|
Something went wrong ... Please have a look at my logs. |
jreback
added
Still Needs Manual Backport
and removed
Still Needs Manual Backport
labels
|
@TomAugspurger did this get backported successfully or do i still need to do it manually? |
|
#32647 backported it. I think the thing about the error is from the auto-backport and Jeff's manual request kicking in around the same time, so the second one errored since the backport was already created (maybe). |
|
right i am sure not if things backport so i usuually kick the bot which i think is safe (it won’t do it twice) but found that if it needs a manual backport it shows immediately which is good |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff