-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Dataframe.groupby aggregations with categorical columns lead to incorrect results. #32546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
16cb58e
first attempt
MarcoGorelli fff989f
condition for categorical
MarcoGorelli 1356da9
gh number
MarcoGorelli f0a3cb1
Merge remote-tracking branch 'upstream/master' into 32494
690591b
use is_categorical
fa0cb85
whatsnew
967c2e8
Merge remote-tracking branch 'upstream/master' into 32494
08632f2
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli 9d4d86c
reindex result
MarcoGorelli 69c9513
remove blank lines
MarcoGorelli da62141
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli c9d9f81
fix for series case too
MarcoGorelli 5586631
correct test
MarcoGorelli dd14e52
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli fc66150
add comment about unobserved categories in categorical case
MarcoGorelli 32bd5b6
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli cc5022e
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli b9cdde9
is_categorical -> is_categorical_dtype
MarcoGorelli 016f5fa
dont reindex if observed is True, add short description of test, para…
MarcoGorelli 869e1f5
assert frame equal -> assert series equal
MarcoGorelli c3db9a7
don't special case the reindexing
MarcoGorelli d6043ec
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli 0725ddf
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli c9b9881
use observed fixture
MarcoGorelli c8a248b
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli c335221
Merge remote-tracking branch 'upstream/master' into 32494
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.