Skip to content

CLN: remove SingleBlockManager.get_values #32522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2020
Merged

CLN: remove SingleBlockManager.get_values #32522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c23b079
CLN: remove SingleBlockManager.get_values
jbrockmendel Mar 7, 2020
bd082d4
Merge branch 'master' of https://github.com/pandas-dev/pandas into mg…
jbrockmendel Mar 7, 2020
caeb1bd
Merge branch 'master' of https://github.com/pandas-dev/pandas into mg…
jbrockmendel Mar 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pandas/core/internals/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,10 +1596,6 @@ def internal_values(self):
"""The array that Series._values returns"""
return self._block.internal_values()

def get_values(self) -> np.ndarray:
""" return a dense type view """
return np.array(self._block.to_dense(), copy=False)

@property
def _can_hold_na(self) -> bool:
return self._block._can_hold_na
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ def _internal_get_values(self):
numpy.ndarray
Data of the Series.
"""
return self._data.get_values()
blk = self._data._block
return np.array(blk.to_dense(), copy=False)

# ops
def ravel(self, order="C"):
Expand Down