Skip to content

DOC: Clean up of DataFrame.ewm #32231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

DOC: Clean up of DataFrame.ewm #32231

wants to merge 3 commits into from

Conversation

sursu
Copy link
Contributor

@sursu sursu commented Feb 25, 2020

Didn't know how to expand my previous Pull Request: #32212, as I have already deleted the files on my machine.

Here are the screenshots, @WillAyd:

image

image

In the first image a controversial change might be: log(0.5) -> -ln(2).
The Notes have been expanded with a simple example from the provided link.

@pep8speaks
Copy link

pep8speaks commented Feb 25, 2020

Hello @sursu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 74:87: W291 trailing whitespace
Line 80:85: W291 trailing whitespace
Line 81:27: W291 trailing whitespace
Line 84:42: W291 trailing whitespace
Line 85:88: W291 trailing whitespace
Line 88:1: E101 indentation contains mixed spaces and tabs
Line 88:1: W191 indentation contains tabs
Line 89:1: W191 indentation contains tabs
Line 89:71: W291 trailing whitespace
Line 90:1: W191 indentation contains tabs
Line 92:1: E101 indentation contains mixed spaces and tabs
Line 92:77: W291 trailing whitespace
Line 96:5: E101 indentation contains mixed spaces and tabs
Line 96:5: W191 indentation contains tabs
Line 97:5: E101 indentation contains mixed spaces and tabs
Line 97:5: W191 indentation contains tabs
Line 97:20: W291 trailing whitespace
Line 98:5: E101 indentation contains mixed spaces and tabs
Line 98:5: W191 indentation contains tabs
Line 99:5: E101 indentation contains mixed spaces and tabs
Line 99:5: W191 indentation contains tabs
Line 100:1: W293 blank line contains whitespace
Line 102:84: W291 trailing whitespace
Line 103:88: W291 trailing whitespace
Line 104:67: W291 trailing whitespace
Line 107:84: W291 trailing whitespace
Line 109:83: W291 trailing whitespace
Line 110:80: W291 trailing whitespace
Line 113:34: W291 trailing whitespace
Line 114:36: W291 trailing whitespace

Comment last updated at 2020-02-25 04:03:39 UTC

@WillAyd
Copy link
Member

WillAyd commented Feb 25, 2020

Didn't know how to expand my previous Pull Request: #32212, as I have already deleted the files on my machine.

Can you continue back in that PR? Comments are already filed therein so shouldn't open a new PR as it makes things more difficult to track

If you don't have on your machine just pull from your remote branch to restore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: clean up DataFrame.ewm
3 participants