REF/TST: method-specific files for combine, update; parametrize #32228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Refactor
simonjayhawkins
approved these changes
Feb 25, 2020
| ) | ||
| def test_update_dtypes(self, other, dtype, expected): | ||
| def test_concat_empty_series_dtypes_match_roundtrips(self, dtype): |
There was a problem hiding this comment.
this change looks good but better if not done at the same time as a move (in future). could any of the dtype fixtures in conftest be used here instead? (as a follow-up)
| ("category", "category", "category"), | ||
| ("category", "object", "object"), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
again keep test refactoring separate from moving things. (in future)
|
Thanks @jbrockmendel |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.