CLN/REF: Split up / clean Categorical constructor tests #32211
Conversation
| dtype = CategoricalDtype(categories=["a", "b", "c"]) | ||
|
|
||
| # empty codes should not raise for floats | ||
| Categorical.from_codes([], dtype.categories) |
There was a problem hiding this comment.
did this get lost or moved?
There was a problem hiding this comment.
I had removed that because it seemed duplicative given that we have a test_constructor_empty test. Looking now I see that it isn't using from_codes so I can add another test for that specifically.
| dtype = CategoricalDtype(categories=["a", "b", "c"]) | ||
|
|
||
| # empty codes should not raise for floats |
There was a problem hiding this comment.
can you retain this comment and the one on L552 describing the choice of parametrizations
There was a problem hiding this comment.
Do you mean the inline comments from L540 and L552? This comment (L543) I find a little confusing because we're testing an empty list rather than an empty float array
|
LGTM pending green (the failure is unrelated, but id rather be patient all the same) |
|
@jbrockmendel Looks like we're green after fixing CI, thanks for the review |
|
thanks @dsaxton |
…2211) * Split / parametrize * Dedupe some code * Parametrize * Add back from_codes for empty * Add comment
No description provided.