CLN: simplify CategoricalIndex._simple_new #32204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonjayhawkins mypy is complaining that the _simple_new signature doesnt match Index's. Suggestions? |
pandas/core/indexes/category.py
Outdated
|
|
||
| @classmethod | ||
| def _simple_new(cls, values, name=None, dtype=None): | ||
| def _simple_new(cls, values: Categorical, name=None): |
There was a problem hiding this comment.
this would fix-up mypy
Suggested change
| def _simple_new(cls, values: Categorical, name=None): | |
| def _simple_new(cls, values: Categorical, name=None, dtype=None): |
and then assert dtype is None or CategoricalDtype?
There was a problem hiding this comment.
maybe a docstring/comment to say dtype is for compatibility with Index._simple_new and not used, but if specified and not CategoricalDtype will raise.
…eate_categorical
WillAyd
reviewed
Feb 24, 2020
| @@ -136,12 +136,3 @@ def test_construction_with_categorical_dtype(self): | |||
|
|
|||
| with pytest.raises(ValueError, match=msg): | |||
| Index(data, ordered=ordered, dtype=dtype) | |||
|
|
|||
| def test_create_categorical(self): | |||
There was a problem hiding this comment.
Does this no longer work? I think should keep the test no?
There was a problem hiding this comment.
the method it is testing is removed
jbrockmendel
added
Clean
Constructors
|
thanks |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.