TST: show_versions test with unmerged commits #32139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
the
Testing
|
Closing pending investigation in #32120. |
|
Re-opened, the issue wasnt with un-merged commits, but with git worktree. re-using versioneer code handles the problem. |
|
gentle ping @simonjayhawkins @WillAyd ; this is workflow-affecting |
WillAyd
reviewed
Feb 26, 2020
| import pandas as pd | ||
|
|
||
|
|
||
| @pytest.mark.filterwarnings( |
There was a problem hiding this comment.
Are these actually required as part of this change? The linkage here with the rest of the PR isn’t totally clear
There was a problem hiding this comment.
these are just because its annoying to have in the output
|
OK thanks @jbrockmendel Heads up - I’m at CZI this week so may be slow to respond to some of your other PRs. Should catch up over the weekend at the latest |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff