Skip to content

CLN: NDFrame.__init__ unnecessary code #32131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

jbrockmendel
Copy link
Member

Make methods into classmethods where feasible, annotate in a couple of places.

Removes nonsense test (constructs an invalid NDFrame)

Preparatory for making a potential fastpath _from_mgr constructor.

attrs is never passed. Is there a plan to do so @TomAugspurger ?

@jreback jreback added this to the 1.1 milestone Feb 22, 2020
@jreback jreback merged commit 9aa9e4f into pandas-dev:master Feb 22, 2020
@jreback
Copy link
Contributor

jreback commented Feb 22, 2020

great

@jbrockmendel jbrockmendel deleted the ndframe-init branch February 22, 2020 16:39
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants