Skip to content

CLN: clean-up show_versions and consistently use null for json output #32042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2020

Conversation

simonjayhawkins
Copy link
Member

note changes to LC_ALL and LOCALE, null is already used for dependencies on master, see blosc and feather.

master

{
  "system": {
    "commit": "a7ecced88a42c426bf61016c0131cab023c0cdff",
    "python": "3.7.5.final.0",
    "python-bits": 64,
    "OS": "Windows",
    "OS-release": "10",
    "machine": "AMD64",
    "processor": "Intel64 Family 6 Model 58 Stepping 9, GenuineIntel",
    "byteorder": "little",
    "LC_ALL": "None",
    "LANG": "en_GB.UTF-8",
    "LOCALE": "None.None"
  },
  "dependencies": {
    "pandas": "1.1.0.dev0+497.ga7ecced88",
    "numpy": "1.17.2",
    "pytz": "2019.3",
    "dateutil": "2.8.0",
    "pip": "19.3.1",
    "setuptools": "41.6.0.post20191030",
    "Cython": "0.29.13",
    "pytest": "5.2.2",
    "hypothesis": "4.36.2",
    "sphinx": "2.2.1",
    "blosc": null,
    "feather": null,
...

this pr

{
  "system": {
    "commit": "2ac9d30f302e59de035cbea89188d5421212b000",
    "python": "3.7.5.final.0",
    "python-bits": 64,
    "OS": "Windows",
    "OS-release": "10",
    "Version": "10.0.18362",
    "machine": "AMD64",
    "processor": "Intel64 Family 6 Model 58 Stepping 9, GenuineIntel",
    "byteorder": "little",
    "LC_ALL": null,
    "LANG": "en_GB.UTF-8",
    "LOCALE": {
      "language-code": null,
      "encoding": null
    }
  },
  "dependencies": {
    "pandas": "1.1.0.dev0+500.g2ac9d30f3",
    "numpy": "1.17.2",
    "pytz": "2019.3",
    "dateutil": "2.8.0",
    "pip": "19.3.1",
    "setuptools": "41.6.0.post20191030",
    "Cython": "0.29.13",
    "pytest": "5.2.2",
    "hypothesis": "4.36.2",
    "sphinx": "2.2.1",
    "blosc": null,
...

console output is unchanged

INSTALLED VERSIONS
------------------
commit           : 2ac9d30f302e59de035cbea89188d5421212b000
python           : 3.7.5.final.0
python-bits      : 64
OS               : Windows
OS-release       : 10
Version          : 10.0.18362
machine          : AMD64
processor        : Intel64 Family 6 Model 58 Stepping 9, GenuineIntel
byteorder        : little
LC_ALL           : None
LANG             : en_GB.UTF-8
LOCALE           : None.None

pandas           : 1.1.0.dev0+500.g2ac9d30f3
numpy            : 1.17.2
pytz             : 2019.3
dateutil         : 2.8.0
pip              : 19.3.1
setuptools       : 41.6.0.post20191030
Cython           : 0.29.13
pytest           : 5.2.2
hypothesis       : 4.36.2
sphinx           : 2.2.1
blosc            : None
feather          : None
...

@@ -64,7 +64,7 @@
Label = Optional[Hashable]
Level = Union[Label, int]
Ordered = Optional[bool]
JSONSerializable = Union[PythonScalar, List, Dict]
JSONSerializable = Optional[Union[PythonScalar, List, Dict]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is serializable

@simonjayhawkins
Copy link
Member Author

hopefully the test added in #32041 will resolve the patch coverage here.

@jbrockmendel
Copy link
Member

needs rebase

@jbrockmendel
Copy link
Member

LGTM

@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback jreback merged commit f6b6c15 into pandas-dev:master Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the clean-show_versions branch March 3, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants