DOC add extended summary, update parameter types desc, update return types desc, and add whitespaces after commas in list declarations to DataFrame.first in core/generic.py #32018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
reviewed
Feb 15, 2020
pandas/core/generic.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| offset : str, DateOffset, dateutil.relativedelta | ||
| offset : str, pandas.tseries.offsets.DateOffset or dateutil.relativedelta |
There was a problem hiding this comment.
Can you leave DateOffset the way it was? (i.e replace pandas.tseries.offsets.DateOffset with DateOffset)
Since we are importing DateOffset in pandas/__init__.py, it's at the top level already
There was a problem hiding this comment.
Got it. I'm leaving it the way it was.
datapythonista
approved these changes
Feb 17, 2020
|
@sagungrp I think CI failure is unrelated but can you merge master and repush to be sure? |
|
@sagungrp can you please merge master into your branch to fix the CI error? This is ready, we can merge after that. Thanks! |
…-docstring-Datetime.first
|
Thanks @sagungrp |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
… types desc, and add whitespaces after commas in list declarations to DataFrame.first in core/generic.py (pandas-dev#32018) Co-authored-by: Sang Agung <sang.agung@kokatto.com> Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff