Skip to content

doc: Add period to parameter description #32005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

DavaIlhamHaeruzaman
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

there are a few errors left:
################################################################################
################################## Validation ##################################
################################################################################

11 Errors found:
        Parameters {'**fields', 'name', 'ordinal'} not documented
        Unknown parameters {'second', 'minute', 'year', 'month', 'quarter', 'hour', 'day'}
        Parameter "year" has no description
        Parameter "month" has no description
        Parameter "quarter" has no description
        Parameter "day" has no description
        Parameter "hour" has no description
        Parameter "minute" has no description
        Parameter "second" has no description
        Parameter "dtype" has no description
        Examples do not pass tests

Copy link
Member

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 15, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavaIlhamHaeruzaman lgtm

@simonjayhawkins simonjayhawkins merged commit 3689e6c into pandas-dev:master Feb 15, 2020
@simonjayhawkins
Copy link
Member

Thanks @DavaIlhamHaeruzaman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants