CLN: organize MultiIndex indexing tests #31863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Feb 11, 2020
pandas/tests/indexes/conftest.py
Outdated
| import pytest | ||
|
|
||
| import pandas._testing as tm | ||
| from pandas.core.indexes.api import Index, MultiIndex | ||
|
|
||
|
|
||
| def _gen_mi(): | ||
| # a MultiIndex used to test the general functionality of the |
There was a problem hiding this comment.
I think "general functionality" is mistakenly repeated twice
There was a problem hiding this comment.
thanks, will update
pandas/tests/indexes/conftest.py
Outdated
| # general functionality of this object | ||
|
|
||
| # See Also: tests.multi.conftest.idx | ||
| major_axis = Index(["foo", "bar", "baz", "qux"]) |
There was a problem hiding this comment.
Can you alternately just construct the mi from tuples? I think would be more readable that way
There was a problem hiding this comment.
This is how it is constructd in the other conftest
jreback
reviewed
Feb 17, 2020
habit, mostly. for some stuff its nice to organize tests within a module |
|
thanks |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
* implement test_take * move test_take, organize tests * cleanup * remove unused imports * isort fixup * typo fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.