Skip to content

REF: use inherit_names for DTI #31468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

REF: use inherit_names for DTI #31468

merged 1 commit into from
Jan 31, 2020

Conversation

jbrockmendel
Copy link
Member

xref #31427, #31433. With all three of these in, we can then remove indexes.datetimelike.DatetimelikeDelegateMixin

Using inherit_names, we also have the option of making tz, tzinfo, dtype cache_readonly if that turns out to make a difference.

@jreback jreback added the Refactor Internal refactoring of code label Jan 31, 2020
@jreback jreback added this to the 1.1 milestone Jan 31, 2020
@jreback jreback added the Datetime Datetime data dtype label Jan 31, 2020
@jreback jreback merged commit 8f1b912 into pandas-dev:master Jan 31, 2020
@jreback
Copy link
Contributor

jreback commented Jan 31, 2020

k great

@jbrockmendel jbrockmendel deleted the inherit-dti branch January 31, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Datetime Datetime data dtype Refactor Internal refactoring of code
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback