Skip to content

TST: make sure fixture params are sorted list #31436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

TST: make sure fixture params are sorted list #31436

merged 1 commit into from
Jan 30, 2020
+1 −1

Conversation

jbrockmendel
Copy link
Member

ATM running tests with --n 4 breaks locally because the tests that get collected dont match across processes.

@jbrockmendel jbrockmendel added Bug Testing pandas testing functions or related to the test suite labels Jan 30, 2020
@jbrockmendel
Copy link
Member Author

cc @TomAugspurger this is workflow-affecting, so somewhat of a priority

TomAugspurger
TomAugspurger approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'd be fine with self-merging changes of this scope.

@TomAugspurger TomAugspurger merged commit 426d445 into pandas-dev:master Jan 30, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jan 30, 2020
@jbrockmendel jbrockmendel deleted the sorted-tests branch January 30, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Bug Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @TomAugspurger