Skip to content

CLN: more consistent error message for construct_from_string wrong type #31387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

CLN: more consistent error message for construct_from_string wrong type #31387

merged 1 commit into from
Jan 31, 2020

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added Error Reporting Incorrect or improved errors from pandas Clean labels Jan 28, 2020
@jbrockmendel
Copy link
Member

LGTM cc @WillAyd

@jreback jreback added this to the 1.1 milestone Jan 31, 2020
jreback
jreback approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@WillAyd WillAyd merged commit 882dbee into pandas-dev:master Jan 31, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 31, 2020

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the construct_from_string-error-messages branch January 31, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@simonjayhawkins @jbrockmendel @WillAyd @jreback