CLN: core.internals #31179
Merged
CLN: core.internals #31179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| assert isinstance(result, Block), type(result) |
There was a problem hiding this comment.
do we need a run-time check? can result be typed as Union[Block, List[Union[Block, List[Block]]]? Might help to type blocks and return type while touching this.
There was a problem hiding this comment.
thats a pretty ugly nested union; ill see if i can get rid of the double-list in the next pass
There was a problem hiding this comment.
@simonjayhawkins is this a deal-breaker? id like to clear the queue
simonjayhawkins
approved these changes
Jan 23, 2020
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some annotations, remove an unused argument, privatize where possible, avoid a runtime/circular import