TST: Replaced try-catch blocks with pytest.raises #31165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jan 21, 2020
| tm.assert_series_equal(a, b, **kwargs) | ||
| msg = "The two Series were equal when they shouldn't have been" | ||
|
|
||
| pytest.fail(msg=msg) |
There was a problem hiding this comment.
I don't think removing this is entirely equivalent; might be root of CI failures
pandas/tests/io/test_sql.py
Outdated
| self.conn.close() | ||
| except Error: | ||
| pass |
There was a problem hiding this comment.
I think this is kind of a "teardown" method of the tests, so not sure this should use an assert instead of try/except
pandas/tests/io/test_sql.py
Outdated
| @@ -538,13 +536,12 @@ class DummyException(Exception): | |||
|
|
|||
| # Make sure when transaction is rolled back, no rows get inserted | |||
| ins_sql = "INSERT INTO test_trans (A,B) VALUES (1, 'blah')" | |||
| try: | |||
|
|
|||
| with pytest.raises(DummyException): | |||
There was a problem hiding this comment.
I don't think we need to assert the exception here, from reading the comment we are just raising it to ensure the transaction is correctly rolled back. I think using a try/except with ignoring the exception makes that clearer.
added 5 commits
January 23, 2020 01:27
jorisvandenbossche
approved these changes
Jan 23, 2020
|
Thanks @MomIsBestFriend ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff